ThunderNetworkRaD/yolks
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(java): new constructor class breaking Forge

Browse source 
The new Java release contains a manifest constructor class with new parameters that older Forge versions do not support. This breaks all older Forge versions and modpacks.

Freezing the versions to a previous known working release. This freeze should be released once Forge backports the changes or decides to abandon old versions, and we'd need newer Java versions. It shouldn't be a significant issue considering old Quay-based images were updated once a year.
This commit is contained in:
softwarenoob 2022-02-07 20:53:35 +02:00
parent 290066dd4f
commit 29258345ff
No known key found for this signature in database
GPG key ID: 727A9A3F4417ED51
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
java/11/Dockerfile
View file

@ -20,7 +20,15 @@
# SOFTWARE. # SOFTWARE.
# #
FROM --platform=$TARGETOS/$TARGETARCH openjdk:11-slim # Hard coded specific Java version to fix issue with manifest constructor class in
# newer Java versions breaking all modpacks and versions that are not using the
# latest Forge release. This should be removed when the manifest constructor class
# issue is backported or if Forge decides to abandon old versions and we need
# newer Java versions. Old Quay images were updated like once a year, so it's ok.
#
# @see https://github.com/McModLauncher/modlauncher/issues/91
FROM --platform=$TARGETOS/$TARGETARCH openjdk:11.0.13-slim
LABEL author="Matthew Penner" maintainer="matthew@pterodactyl.io" LABEL author="Matthew Penner" maintainer="matthew@pterodactyl.io"

10
java/8/Dockerfile
View file

@ -20,7 +20,15 @@
# SOFTWARE. # SOFTWARE.
# #
FROM --platform=$TARGETOS/$TARGETARCH openjdk:8-slim # Hard coded specific Java version to fix issue with manifest constructor class in
# newer Java versions breaking all modpacks and versions that are not using the
# latest Forge release. This should be removed when the manifest constructor class
# issue is backported or if Forge decides to abandon old versions and we need
# newer Java versions. Old Quay images were updated like once a year, so it's ok.
#
# @see https://github.com/McModLauncher/modlauncher/issues/91
FROM --platform=$TARGETOS/$TARGETARCH openjdk:8u312-slim
LABEL author="Matthew Penner" maintainer="matthew@pterodactyl.io" LABEL author="Matthew Penner" maintainer="matthew@pterodactyl.io"