From 29258345ff193a480db55a4e00ba4a3cd5802d03 Mon Sep 17 00:00:00 2001 From: softwarenoob Date: Mon, 7 Feb 2022 20:53:35 +0200 Subject: [PATCH] fix(java): new constructor class breaking Forge The new Java release contains a manifest constructor class with new parameters that older Forge versions do not support. This breaks all older Forge versions and modpacks. Freezing the versions to a previous known working release. This freeze should be released once Forge backports the changes or decides to abandon old versions, and we'd need newer Java versions. It shouldn't be a significant issue considering old Quay-based images were updated once a year. --- java/11/Dockerfile | 10 +++++++++- java/8/Dockerfile | 10 +++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/java/11/Dockerfile b/java/11/Dockerfile index 13f1c95..7feee8b 100644 --- a/java/11/Dockerfile +++ b/java/11/Dockerfile @@ -20,7 +20,15 @@ # SOFTWARE. # -FROM --platform=$TARGETOS/$TARGETARCH openjdk:11-slim +# Hard coded specific Java version to fix issue with manifest constructor class in +# newer Java versions breaking all modpacks and versions that are not using the +# latest Forge release. This should be removed when the manifest constructor class +# issue is backported or if Forge decides to abandon old versions and we need +# newer Java versions. Old Quay images were updated like once a year, so it's ok. +# +# @see https://github.com/McModLauncher/modlauncher/issues/91 + +FROM --platform=$TARGETOS/$TARGETARCH openjdk:11.0.13-slim LABEL author="Matthew Penner" maintainer="matthew@pterodactyl.io" diff --git a/java/8/Dockerfile b/java/8/Dockerfile index 4b2a5ae..5ee3757 100644 --- a/java/8/Dockerfile +++ b/java/8/Dockerfile @@ -20,7 +20,15 @@ # SOFTWARE. # -FROM --platform=$TARGETOS/$TARGETARCH openjdk:8-slim +# Hard coded specific Java version to fix issue with manifest constructor class in +# newer Java versions breaking all modpacks and versions that are not using the +# latest Forge release. This should be removed when the manifest constructor class +# issue is backported or if Forge decides to abandon old versions and we need +# newer Java versions. Old Quay images were updated like once a year, so it's ok. +# +# @see https://github.com/McModLauncher/modlauncher/issues/91 + +FROM --platform=$TARGETOS/$TARGETARCH openjdk:8u312-slim LABEL author="Matthew Penner" maintainer="matthew@pterodactyl.io"